[cosmos] Correct documentation for enableBackgroundEndpointRefreshing default value#33093
[cosmos] Correct documentation for enableBackgroundEndpointRefreshing default value#33093heguro wants to merge 1 commit intoAzure:mainfrom heguro:patch-1
Conversation
|
Thank you for your contribution @heguro! We will review the pull request and get back to you soon. |
|
API change check API changes are not detected in this pull request. |
|
Hi @heguro. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
During client initialization, user has the option to specify connection policy. If no connection policy is supplied, then If a connection policy is supplied and |
I believe this is not correct. My understanding is that it is only treated as false if azure-sdk-for-js/sdk/cosmosdb/cosmos/src/CosmosClient.ts Lines 127 to 131 in 4d652c5 As seen here, For example, when configured as shown below, const client = new CosmosClient({
endpoint: "something",
key: "something",
connectionPolicy: {
requestTimeout: 1_000_000,
// enableBackgroundEndpointRefreshing property is not specified
},
});
Furthermore, this behavior (that the default is |
Packages impacted by this PR
@azure/cosmosIssues associated with this PR
Describe the problem that is addressed by this PR
JSDoc comment and documentation incorrectly state that
enableBackgroundEndpointRefreshingdefaults to false, when the actual default value is true as shown in thedefaultConnectionPolicyobject:azure-sdk-for-js/sdk/cosmosdb/cosmos/src/documents/ConnectionPolicy.ts
Line 50 in fe306bc
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
#15781 (implemented this parameter)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists